search

CartoDB / toolkit

JS library to interact with CARTO APIs in a simple way
https://toolkit-wheat.now.sh
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Use pointRadiusUnits prop & update to deck.gl@8.2.0-alpha.2 #128

Closed simon-contreras-deel closed 4 years ago

simon-contreras-deel commented 4 years ago

Prepare style helpers to work with pointRadiusUnits property.

Do not merge until https://github.com/visgl/deck.gl/pull/4624 will be merged and released

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/toolkit/j45pyf9zo ✅ Preview: https://toolkit-git-use-pointradiusunits-prop.carto-frontend.now.sh

VictorVelarde commented 4 years ago

Looks good regarding to pixel units, ~but we might have some unrelated issues with alpha.2 in other areas: I saw that viewportFeatures fails sistematically on https://toolkit-git-use-pointradiusunits-prop.carto-frontend.now.sh/examples/data/viewport-features.html, and we have to check that~

Forget about viewportFeatures, that example was not adapted to the new event system. I will fix it in another branch, so no worries.