search

CartoDB / toolkit

JS library to interact with CARTO APIs in a simple way
https://toolkit-wheat.now.sh
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Prevent adding the column carotbd_id as aggregation column #138

Closed manmorjim closed 4 years ago

manmorjim commented 4 years ago

This fixes the error column reference "cartodb_id" is ambiguous thrown by Maps API when we add the column cartodb_id whithin the popups.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/toolkit/6r5ozpmqi ✅ Preview: https://toolkit-git-mmorillo-ch79584popup-error-with-cartodb-id-column.carto-frontend.now.sh

manmorjim commented 4 years ago

Please, take a look at the comment I wrote in CH also.

manmorjim commented 4 years ago

I would filter it in Layer class (methods _addPopupFields && _getStyleField). At least, my idea was to avoid adding more logic in Source, since we could have to add same logic in other source types

good point, done!