search

CartoDB / torque

Temporal mapping for CARTO
http://cartodb.github.com/torque/
BSD 4-Clause "Original" or "Old" License
397 stars 129 forks source link

Audit dependencies #300

Closed dgaubert closed 5 years ago

dgaubert commented 5 years ago

I will need some help from @CartoDB/frontend-team to review this PR.

cc/ @CartoDB/rt-managers

dgaubert commented 5 years ago

Basically, I need to know if this PR will break something in CARTO.js as they are using torque.js#master.

jesusbotella commented 5 years ago

Let me use this branch as the source for torque and do a test run. If it passes, I assume that everything will be OK with CARTO.js as we have some tests related to Torque.

jesusbotella commented 5 years ago

I have just done it and all tests pass in green, so let's say that it's OK :)

Nevertheless, whenever this PR is merged, we should update CARTO.js to point to new Torque's revision and deploy the new version to Builder.

dgaubert commented 5 years ago

@jesusbotella, after clarifying these points, can I move forward?

jesusbotella commented 5 years ago

Yes, I would say so!