Remove PROBE_CALIBRATE and associated helper function

Cartographer3D / cartographer-klipper

https://docs.cartographer3d.com/

GNU General Public License v3.0

37 stars 23 forks source link

Remove PROBE_CALIBRATE and associated helper function #81

Closed krautech closed 3 days ago

krautech commented 6 days ago

Description

Cleaned up and removed PROBE_CALIBRATE and relevant command register and helper function

Checklist

The following relevant macros have been tested:

[ ] CARTOGRAPHER_CALIBRATE
[ ] PROBE
[ ] PROBE_ACCURACY
[ ] CARTOGRAPHER_THRESHOLD_SCAN
[ ] CARTOGRAPHER_TOUCH CALIBRATE=1
[ ] CARTOGRAPHER_TOUCH
[ ] CARTOGRAPHER_TOUCH METHOD=manual
[ ] BED_MESH_CALIBRATE

krautech commented 5 days ago

This is in theory a breaking change. I suppose as minimum we should mark it as a "feature" to indicate something changed more than a patch. I have added the breaking change label, which would indicate that the next version becomes v2, make it a feature if you think it should be v1.2 instead.

I wouldnt think so, nobody should be using PROBE_CALIBRATE to begin with since it wasnt used for anything cartographer related in a long time. Thus the removal.