search

Cartucho / OpenLabeling

Label images and video for Computer Vision applications
Apache License 2.0
926 stars 265 forks source link

Adding more image extensions #20

Closed TheCamilovisk closed 6 years ago

TheCamilovisk commented 6 years ago

Hi @Cartucho!

I'm adding more image extension options to load. The dictionary model was chosen to make it easier to select and add more extensions.

Cartucho commented 6 years ago

Hello @TheCamilovisk ! Sorry for the delayed response, I've been on vacation. I will review the code.

TheCamilovisk commented 6 years ago

Hi @Cartucho! Do not worry! I was wondering if there is another way of implementing that idea, so I closed the request. But feel free to review! Thank you!

Cartucho commented 6 years ago

@TheCamilovisk I found both the new features very interesting. Do you think we can separate the two commits into two separate PR's? Like this one would be just about the image extensions and then there would be another one for the squared bounding boxes?

TheCamilovisk commented 6 years ago

Hi @Cartucho! About the image loading, I think you're right. It' a nice and simple solution. I don't know if it would be any problem with other file types, but I did not find any problems. About the square box feature, I'll create another PR for this!

Thanks for you time!

Cartucho commented 6 years ago

According to OpenCV's imread docs:

If the image cannot be read (because of missing file, improper permissions, unsupported or invalid format), the function returns an empty matrix ( Mat::data==NULL ).

So we can use this :+1: