search

Cartucho / OpenLabeling

Label images and video for Computer Vision applications
Apache License 2.0
926 stars 266 forks source link

Add requirements.txt & .gitignore #35

Closed jamietownsend closed 5 years ago

Cartucho commented 5 years ago

Thanks!

What are those directories in the .gitignore? .idea/ venv/

Also shouldn't we replace line 49 with:

  1. python -mpip install -U pip
  2. python -mpip install -U -r requirements.txt

People need to have pip installed first, and with python -mpip we make sure it works in all OS's. What do you think?

jamietownsend commented 5 years ago

What are those directories in the .gitignore? .idea/ venv/

.idea comes from the IDE I'm using - PyCharm (https://www.jetbrains.com/pycharm/) venv comes from the python virtual environment I create to keep all the pip installations specific to a this particular project (so my other projects don't stop working if I need a different version of something here).

Also shouldn't we replace line 49 with:

  1. python -mpip install -U pip
  2. python -mpip install -U -r requirements.txt

People need to have pip installed first, and with python -mpip we make sure it works in all OS's. What do you think?

I guess so - I don't really know. I've only started with Python a couple of days ago. pip seems to be available in all Python environments (on my machine) by default. Updating it's probably a good idea to update it. Your alternative command to install from requirements.txt also works on my machine, so I guess that's a good idea too.

Cartucho commented 5 years ago

Cool! So let's keep those lines in the .gitignore and update the other lines.

Do you mind separating the commits for each of the PR's? So that #35 would be only about the .gitignore and requirements.txt and #36 about the export.