Carve / qbittorrent-webui-cjratliff.com

qbittorrent dark theme based on colors used on my portfolio site - cjratliff.com
209 stars 17 forks source link

Selection/hover color could be improved slightly for a more polished feel #38

Closed iGerman00 closed 12 months ago

iGerman00 commented 12 months ago

Love the theme, was looking for something exactly as low key as this.

At lines 24-27 in dynamicTable.css, there is styling for the hover and selection of the table items, which looks like this: ishare-1698602617

In my opinion, there is too much contrast, leaving it looking a bit out of place given that the rest of the theme is in a darker domain. Inexplicably, it uses the text color var for the background, and the background color var for the text color.

I propose changing it to:

.dynamicTable tbody tr:hover {
    background-color: var(--darkmode-background-alt2);
    color: var(--darkmode-text-alt)
}

For a much cleaner look, while still definitively appearing as a selection: ishare-1698602542


In a similar vein, the progress bar styling seems a little too bright. ishare-1698602888

While the cyan ones are okay, the white ones do stand out a bit and look "unthemed". I haven't played around with fixing that but hopefully you'll consider.

Carve commented 12 months ago

Ya I actually intended to do this as well as change the progress bar for 0%, among a few other stylistic updates.

Carve commented 12 months ago

Updated (among a few other things) in today's release. image