Carvera-Community / Carvera_Community_Firmware

GNU General Public License v3.0
3 stars 0 forks source link

clarify ATC tool detection failure messages #12

Closed faecorrigan closed 6 hours ago

faecorrigan commented 6 hours ago

This is a pull request from the brooklikeme repo that never got implemented. The ATC error messages use "ERROR: Tool confliction occured, please check tool rack!" as the error message for when the tool sensor detects a tool already in the rack and when there is not a tool in the rack to pick up. This is a simple clarification of that information

https://github.com/brooklikeme/Smoothieware/pull/1/commits/695a2499217f8f42ce5436beea415b5857d0f7a8#diff-cffcd3ae63a965f7278f81fe46497b8a30bf5d0518f9f38b9c31156af14d0222L843

Print different messages for when a tool was expected but not detected and when a tool was not expected but was detected.

For context: I just had my first ATC tool drop failure this morning while I was away from my Carvera and wasn't sure if it was due to:

The laser mistakenly detecting the presence of a tool where the tool to be dropped was supposed to go, possibly because I'd just gotten done milling a part that threw a lot of aluminum chips, or: The ATC tried to drop the tool, failed, and the laser rightly detected that the tool had not been dropped Having different messages for the two scenarios would help me know which of those two scenarios to start looking at first.

faecorrigan commented 6 hours ago

clarify ATC tool detection failure messages