search

Casa / Casa-Node-Manager

Configures and launches docker instances to run the various services on the device
MIT License
29 stars 3 forks source link

Casa Extension doesn't work on Firefox #9

Closed ben-kaufman closed 5 years ago

ben-kaufman commented 5 years ago

The Casa Firefox extension is not whitelisted in the cors.js file (https://github.com/Casa/Casa-Node-Manager/blob/master/middlewares/cors.js#L3), this causes the extension API calls to be blocked.

stridentbean commented 5 years ago

Firefox uses a different UUID for each installation, so we're not able to whitelist a specific 'moz-extension://XXXX' like we could with Chrome.

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1372288

ben-kaufman commented 5 years ago

Thanks for the reply @stridentbean. Yes you are right that the ID is randomly generated per user thus it won't be possible to whitelist it in the CORS (at least not without opening it to opening the CORS to all moz-extension://). However, it is possible to bypass that by asking for permission from the extension manifest. I have opened a PR for that in the Extension repo: https://github.com/Casa/Casa-Extension/pull/2 I would appreciate if you could review that PR.