search

Casal2 / CASAL2

Integrated Population Dynamics Model (Casal2)
https://casal2.github.io
GNU General Public License v2.0
27 stars 24 forks source link

add predation as electivity #251

Closed smormede closed 3 months ago

smormede commented 6 years ago

Predation currently has Holling function only. Copy the electivity predation module from SPM, required urgently.

smormede commented 6 years ago

@Zaita can you look into bringing in the SPM module on the predator-prey function using electivity.

@SamikDatta can you then copy the information from the SPM manual into the Casal2 manual and check that the names are right etc. It will also need tested and unit-test.

Zaita commented 6 years ago

This process already exists as "Mortality Prey Suitability"

type: mortality_prey_suitability

SamikDatta commented 5 years ago

Jinging is now testing this module, fingers crossed there is nothing left to do and this issue can be closed.

Zaita commented 5 years ago

@SamikDatta How is this going?

SamikDatta commented 5 years ago

I'm about to submit the changes to the manual, copied and adapted from the relevant section in SPM. @Zaita - I'm not 100% sure if any of the variable names have changed when moving this functionality to Casal2 (reading through the .cpp and .h file for MortalityPreySuitability it looks the same, although I can't be positive. Does Jingjing have a unit test for it? In which case it will tell me if I need to modify the manual further.

Zaita commented 5 years ago

No unit tests were implemented when this process was ported.

SamikDatta commented 5 years ago

I'll check with Jingjing if she has some kind of test ready which we can incorporate.

SamikDatta commented 5 years ago

Resubmitted now, @Zaita , should be fine in terms of the file history.

Casal2 commented 3 months ago

Closing issue. Been a few years and will be placed on a roadmap if required.