Dirichlet multinomial - Githubissues

Casal2 / CASAL2

Integrated Population Dynamics Model (Casal2)

https://casal2.github.io

GNU General Public License v2.0

27 stars 24 forks source link

Dirichlet multinomial #405

Closed NIWAFisheriesModelling closed 2 years ago

NIWAFisheriesModelling commented 2 years ago

Please check that the PR fulfills these requirements
[x] The commit message follows the Contributor Guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[x] Documents have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

The Dirichlet multinomial likelihood, referencing Thorson et al. (2017) Fisheries Research.

What is the current behavior? (You can also link to an open issue here)

This feature does not exist.

What is the new behavior (if this is a feature change)?

Craig Marsh has added the Dirichlet multinomial likelihood.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

Other information:

Issue #401

NIWAFisheriesModelling commented 2 years ago

Added a TestModel "LIM_tc_Dm" to show how to configure the theta parameter (as log_theta).

Stock Synthesis 3 estimates log_theta instead of theta. Search "dirichlet_Parm" in SS_objfunc.tpl and SS_write_report.tpl.

@Craig44 Please indicate if additional tests are needed.