search

Casal2 / CASAL2

Integrated Population Dynamics Model (Casal2)
https://casal2.github.io
GNU General Public License v2.0
27 stars 24 forks source link

CategoryList report not compatiable with Casal2 R library function extract.mpd() #406

Closed Craig44 closed 2 years ago

Craig44 commented 2 years ago

The Simple Example here model has a report type category_list. When I use extract.mpd() on the run.log and estimate.log I get an error. I have tracked the error to this report. This @report needs to be rewritten so that it is compatible with the R library extract function, or removed from the example config files.

The same for @report type mpd when estimating

NIWAFisheriesModelling commented 2 years ago

What information should be in the reports of type category_list? It is not described in the user manual.

Craig44 commented 2 years ago

I am not sure could be a legacy report, I am not familiar with/never have used it. However, recently I was doing some training with the simple example model which errored out. Perhaps if there is no information on this report. Remove it and take it out of the example config files.

NIWAFisheriesModelling commented 2 years ago

I will remove the category_list report and fix the mpd report.

Craig44 commented 2 years ago

It is worth noting the mpd report is used by casal2 -M and -E which I think is related to the MPD classs

NIWAFisheriesModelling commented 2 years ago

Addressed in commits on 2022-09-09, e.g., commit ed1376459bbab6601b30bed2ea3ffb4057ce6b3d.