Jenkins Issue

[JanStevens]

Hello,

Using jenkins on our setup we get the following errors (rake spec)

An error occurred in an after hook
  NameError: constant Object::Voucher not defined
  occurred at /var/lib/jenkins/jobs/project/workspace/vendor/bundle/ruby/2.1.0/gems/with_model-1.1.0/lib/with_model/constant_stubber.rb:18:in `remove_const'

F
An error occurred in an after hook
  NameError: constant Object::Voucher not defined
  occurred at /var/lib/jenkins/jobs/project/workspace/vendor/bundle/ruby/2.1.0/gems/with_model-1.1.0/lib/with_model/constant_stubber.rb:18:in `remove_const'

F
An error occurred in an after hook
  NameError: constant Object::Voucher not defined
  occurred at /var/lib/jenkins/jobs/project/workspace/vendor/bundle/ruby/2.1.0/gems/with_model-1.1.0/lib/with_model/constant_stubber.rb:18:in `remove_const'

The Voucher is with_model object:

with_model :voucher do
    table do |t|
      t.string :ticket
    end

    model do
      attr_accessor :validation_hash
      validates :ticket, ticket: true
    end
  end

Any idea/solution? Thanks

[nertzy]

Capitalize Voucher:

  with_model :Voucher do
    table do |t|
      t.string :ticket
    end

    model do
      attr_accessor :validation_hash
      validates :ticket, ticket: true
    end
  end

[amarshall]

@nertzy Hmm, I’m not convinced that’s the issue here, though. The error would’ve been “voucher is not allowed as a constant name”. Plus we camelize it here and it’s capital-V Voucher in the error shown.

@JanStevens did changing it to :Voucher as above fix the issue?

[JanStevens]

Yea it did fix the issue... Thanks!

[amarshall]

Interesting.

[nertzy]

We should do something to make this situation more discoverable through better error messaging.

[amarshall]

Yea, I know we want to deprecate passing snake-cased symbols, but I’m still not convinced that’s the issue here.

The error they were getting doesn’t match the apparent fix, and changing several of the with_model specs to call with_model with e.g. :blog_post instead of :BlogPost doesn’t raise any exceptions and is in fact completely green, so I can’t reproduce the issue.

[JanStevens]

Thats why its only a Jenkins issue, locally I didnt saw any problems using :Voucher our :voucher

[nertzy]

@JanStevens Are you on the latest version of with_model? (1.1.0)

[JanStevens]

yes!

[amarshall]

It’s also odd that the error only occurs on removal, not creation. This implies that for some reason either:

• The original constant isn’t being created correctly, but also isn’t raising an exception (or it’s getting rescued somewhere).
• The constant is removed during the test, or being removed multiple times. The latter could maybe happen if there were two with_model blocks for the same test.