search

CaseyBakey / chaosp

Customized Hybrid AOSP (CHAOSP)
29 stars 10 forks source link

Make MicroG an option during the build. #15

Closed AreYouLoco closed 1 year ago

AreYouLoco commented 3 years ago

As stated in the title. Maybe you could add support for microg? Or point me how to integrate it in the build process. Thx for your work!

CaseyBakey commented 3 years ago

Hello there

microg was in fact included in the RattlesnakeOS custom config repo example (https://github.com/RattlesnakeOS/example-custom-config-repo) but I did get rid of it since I wasn't satisfied with it.

Take a look at my fork that is used when compiling CHAOSP, and particularly (this commit and this commit)

You can fork your own version of this repo, reverting my commits about microg to try it out.

If you manage to make it working and make it conditional, I would accept your PR.

Regards ;)

arolano commented 2 years ago

FWIW there appears to be now several "flavors" of MicroG with varying restrictiveness (one by CalyxOS which seems to restrict it to Google Play's stuff by packagename, and one by nickrbogdanov which checks by fingerprint.

So maybe ideally someone could make it possible to choose the implementation

https://github.com/RattlesnakeOS/microg/issues/4

arolano commented 2 years ago

Done a fork with MicroG re-enabled

I changed the variable in build.sh to my forked example-custom-config-repo.git with those commits reverted.

Do I need to supply any option to make it build with MicroG or do I just need to "go and build" now ?

CaseyBakey commented 2 years ago

If you didn't create such option, I guess you don't have to call it