search

CashScript / cashscript

⚖️ Easily write and interact with Bitcoin Cash smart contracts
https://cashscript.org
MIT License
112 stars 79 forks source link

Change to network options of the Cashscript SDK #133

Closed mr-zwets closed 1 year ago

mr-zwets commented 1 year ago

Pull request to addresses issue #132

rkalis commented 1 year ago

Awesome! One thing: these are breaking changes so would require a version upgrade to 0.8.0, which I'd rather not do for such small changes. Could you keep 'testnet' as an alias for 'testnet3' and 'staging' as an alias for 'chipnet' and mark them as "deprecated" in the change notes. You don't need to re-add them to the website docs. But I just want to make sure that if people are still using 'testnet' or 'staging' in their code it doesn't break.

mr-zwets commented 1 year ago

Makes sense! Just changed the MR so the old options are still available. I kept 'staging' as an alias for testnet4, this seemed more logical to me, but I can change it if you want