CashlessSociety / cashless-ui

Open source implementation of protocol described here: https://cashless.social.
Mozilla Public License 2.0
7 stars 1 forks source link

EPIC: Sign in / join / 'create check book' - with email only #7

Open utunga opened 3 years ago

utunga commented 3 years ago
image

As always remember to check Figma for definitive designs

utunga commented 3 years ago

Depends on changes to messaging protocol to support this

https://github.com/CashlessSociety/cashless-express/issues/6

utunga commented 3 years ago

OK so JOIN workflow is as follows

  1. Since they are not logged in there is a 'join' (?) button somewhere

  2. They click join and they see a page a bit like this ... but it has an option to authenticate via Google (other options to be added later) image

  3. If they authenticate via google it prepopulates their name and photo and they can edit these and then click 'sign up'

  4. If they choose not to authenticate via Google, then the next screen is a 'send me a magic link' screen where they can type an email, or 'bookmark this page'. Main button is take me to home page... or actualyl not sure..

jwu910 commented 3 years ago

https://github.com/firebase/firebaseui-web-react

Might be able to save some time if we use a pre-styled react component for auth.

Couldnt find pictures of the sample, but if you want to give this a shot, see if it is a direction we want to go in for the sake of time, too

utunga commented 3 years ago

@karenkun I'm really thinking we should take the google authentication aspect out of this user story ... if you agree lets move it back to.. uh.. "ready for design" ... so you can make that change visually?

(And yeah, visual should be the definitive)

Then maybe I add another user story for authenticating via google

This is because (a) authenticating by google is a 'nice to have' (b) from a dev perspective its quite a bit more complex to have to add that as well

karenkun commented 3 years ago

So just to confirm, if we remove the Google Auth then the user can only login using the magic link.

utunga commented 3 years ago

Yup... at least until we add it back but yes.

DAHuerta commented 3 years ago

Hey Miles can you reaccess the requirements of this ticket. According to the comments, it looks like there are some changes to how the users sign in.

utunga commented 3 years ago

@DAHuerta well spotted. For what it's worth I did try to update the acceptance criteria - at the top - to reflect the changed requirements from the requirements.

Specifically, dropping the requirement for a google login (or at least moving that to a different card). @karenkun commentwas that its probably not too confusing to have a mockup that includes the future state with both options avialable, and just tell the programmer (which actually might end up being me??) to just not show the bit they haven't coded yet.

What do you think ... does that work? Or should we amaybe change the images?

utunga commented 3 years ago

We might need to add some restrictions around the profile image and the upload experience - maybe as a separate card.

Just noting that the colony ux for something similar looks like this (note the restrictions on the profile image)

image image

Actually i found the code that does this as well just in case its interesting to study and learn from (not copy wholus bolus) https://github.com/JoinColony/colonyDapp/blob/b0ee38b2765b86303ab434a1c76f1f297ca1ca2a/src/modules/users/components/UserProfileEdit/UserAvatarUploader.tsx

utunga commented 3 years ago

We merged the PR but moving this epic back to 'in progress' until the designs are figured out and all the acceptance criteria checked and any other things we need to address sorted.. I will be adding issues for things we need to address.

luandro commented 3 years ago

This is basically done, just missing some UI work.

utunga commented 3 years ago

tagging you in on this @karenkun