CasparCG / client

Client software primarily used with the CasparCG Server software for audio and video playout, to control graphics and recording, but it can also be used for other tasks within television broadcast.
https://casparcg.com
GNU General Public License v3.0
284 stars 99 forks source link

Add Custom Shell Command #199

Open dimitry-ishenko opened 8 years ago

dimitry-ishenko commented 8 years ago

I have a number of custom scripts that control various things in the theatre (eg, screen up/down, open/close projector shutter, etc.) It would be very useful to have something similar to the Custom Command, but instead of executing a command on the CasparCG Server, it executes arbitrary shell command.

ghost commented 8 years ago

+1 :)

dimitry-ishenko commented 8 years ago

@Zebiolo I can program it, but I would really like to do it against my earlier patches. If that's OK with you, I can break up my earlier request into small junks that are easy to review and will "feed" them to you one-by-one. What do you think?

ghost commented 8 years ago

I think it's sounds good but i'm not in charge anymore.

1 maj 2016 kl. 17:09 skrev Dimitry Ishenko notifications@github.com:

@Zebiolo I can program it, but I would really like to do it against my earlier patches. If that's OK with you, I can break up my earlier request into small junks that are easy to review and will "feed" them to you one-by-one. What do you think?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

dimitry-ishenko commented 8 years ago

Oh... who is the boss now? Jonas?

ghost commented 8 years ago

No, Jonas don't work for SVT.

1 maj 2016 kl. 17:32 skrev Dimitry Ishenko notifications@github.com:

Oh... who is the boss now? Jonas?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

dimitry-ishenko commented 8 years ago

@Zebiolo so who is in-charge then?

ghost commented 8 years ago

I guess someone from SVT should chime in an answer that.

HellGore commented 8 years ago

@Zebiolo I have no problem if you decide stuff regarding the client before the new client developer starts working.

ghost commented 8 years ago

@HellGore Have you seen dimitry-ishenko's PR?

I think we should do something about the branches before we do any major refactoring. The next branch is basically code for the 2.1 release and master is for the 2.0 series. We should branch off master as 2.0 and make the next branch the new master. I have already done this in my tree. I can send a PR against your master as soon as you are ready (branched off master).

@dimitry-ishenko your changes should go ontop off the new master.

What do you say? Suggestions?

Edit: Maybe we should just tag the master and merge in the next branch? We can always branch from the tag later.

dimitry-ishenko commented 8 years ago

@Zebiolo if you are not planning to maintain the 2.0 series any more, then I would do as you suggested -- tag the current master, merge next into it and continue developing 2.1 in master. If you need to do some bug fixes for 2.0 in the future, you can always branch from the tag.

I will rebase my patches in the next few days

dimitry-ishenko commented 8 years ago

@Zebiolo @HellGore or just rename the branches: master -> 2.0 next -> master

I am redoing my changes against next for now and will submit in smaller chunks that are easy to swallow :) Is there anyone ready to receive them?

HellGore commented 8 years ago

Armin starts the 1st of June, and will be the lead developer of the client. He has made a short introduction of himself on the forum.

So currently the answer is no, nobody is ready to receive them at this point. After Armin is up and running he can answer this.

dimitry-ishenko commented 8 years ago

@HellGore thank you. I will check the forums.

dimitry-ishenko commented 8 years ago

I will start queuing up simple changes, so that Armin has some work to do, once he starts on the 1st of June :P

jamesbaber commented 6 years ago

Is any alternative to this feature available? I would like to use this feature in a similar way to @dimitry-ishenko

dimitry-ishenko commented 6 years ago

@jamesbaber well I've been waiting for @dotarmin or someone else to apply my patch set, which sadly never happened. At this point it bit-rotted quite a bit and probably needs to be redone.

I am currently setting up a new CCG server/client and will try to take a look at it in the next few days.

dotarmin commented 6 years ago

@dimitry-ishenko

which sadly never happened.

I couldn't agree more but their has been other more important stuff regarding the CasparCG project that I have been working on the last year.

At this point it bit-rotted quite a bit and probably needs to be redone.

In your fork or how do you mean?

dimitry-ishenko commented 6 years ago

@dotarmin Sorry I wasn't trying to blame you. Just stating the fact of life. I understand everyone has different priorities, so no worries. I hope some day ours will coincide. :smiley:

By bit rot I meant my PR no longer applies and needs to be rebased. I was also thinking of redoing it in a way that minimizes changes to the existing code, so that you are less reluctant to accept it.

dotarmin commented 6 years ago

@dimitry-ishenko

Sorry I wasn't trying to blame you. Just stating the fact of life. I understand everyone has different priorities, so no worries. I hope some day ours will coincide.

No worries, and no hard feelings! It's open source! :smiley: I really agree with you and I wrote that in my previous post but the things I have been working on will end up good for the whole project it-self. Could you add me at skype (same username as here on GitHub)? I would like to discuss some things with you, good stuff haha :smiley:

By bit rot I meant my PR no longer applies and needs to be rebased. I was also thinking of redoing it in a way that minimizes changes to the existing code, so that you are less reluctant to accept it.

I'm not reluctant to accept your PR even if it sounded like when commenting the PR it-self.

dimitry-ishenko commented 6 years ago

@dotarmin I've stopped using skype ever since it's been acquired by "the evil empire" :smile: Feel free to shoot me an email at: di (at) keylimebox (dot) org. We can establish further contact from there.

dimitry-ishenko commented 6 years ago

@dotarmin I will try to hang out on IRC on Monday, if you want to catch me there

dotarmin commented 6 years ago

@dotarmin I've stopped using skype ever since it's been acquired by "the evil empire" :smile: Feel free to shoot me an email at: di (at) keylimebox (dot) org. We can establish further contact fromthere.

@dotarmin I will try to hang out on IRC on Monday, if you want to catch me there

Thanks! I will contact you this week! i have been on vacation for a couple of weeks now but I'm back per today! I can also hang out on IRC today to chat with you! :+1: