search

CasparCG / client

Client software primarily used with the CasparCG Server software for audio and video playout, to control graphics and recording, but it can also be used for other tasks within television broadcast.
https://casparcg.com
GNU General Public License v3.0
278 stars 97 forks source link

[next] Fixed audio levels, require #264 and #265. #268

Closed ghost closed 4 years ago

grahamspr86 commented 4 years ago

This doesn't seem to compile on MacOS

../../src/Widgets/AudioMeterWidget.cpp:118:24: error: no member named 'log10' in namespace 'std'

Need #include <math.h>

Change std::log10 to ::log10

ghost commented 4 years ago

This pull request is over 1 year old and outdated. I don't know why SVT didn't merge it when it was submitted, after all they paid for the change. It seems that the client is unmaintained since i left SVT. Sorry for the inconvenient it may have caused you.

dotarmin commented 4 years ago

@Zebiolo, because the PRs wasn't merged at time of creating those, do you want to fix the conflicts or do you want me to do it? I know the PRs are old now and that's why I'm asking :)

ghost commented 4 years ago

I have already fix it. Poke around in my branch and you’ll find it.

dotarmin commented 4 years ago

I have seen it in your branch but I got confused because number of modified files diff between your fix and the PR. But if I understand u correctly I could basically cherry-pick all changes and close the PRs instead?

Thanks for the help!

ghost commented 4 years ago

Yes

Be aware that you need to update the toolchain on all platforms due to newer Qt and compiler.

dotarmin commented 4 years ago

Yes

Be aware that you need to update the toolchain on all platforms due to newer Qt and compiler.

Great. Thanks. I will update the toolchain on the build servers. Thanks once again!!

dotarmin commented 4 years ago

Fixed by cherry-picking from the Zebiolo/client fork.

Thanks to Zebiolo!