search

CasparCG / server

CasparCG Server is a Windows and Linux software used to play out professional graphics, audio and video to multiple outputs. It has been in 24/7 broadcast production since 2006. Ready-to-use downloads are available under the Releases tab https://casparcg.com.
GNU General Public License v3.0
912 stars 268 forks source link

Remove Git LFS references for all branches #992

Open dotarmin opened 6 years ago

dotarmin commented 6 years ago

Git LFS was introduced for branch v2.1 before it was branched off to v2.2 (now master) to minimise the repository size and the time it took to do a clone. Meanwhile developing v2.2 Beta, more packages were nugetified and the need of Git LFS was dropped.

So what's the issue? Well, we had a community member yesterday having an issue with cloning v2.1 (see #990) because data packs where disabled by me. My sugesstion is to remove Git LFS and have it as before without Git LFS.

Thoughts?

:)

/Armin

gizahNL commented 6 years ago

Another option would be to serve them on a standard http server, update build instructions to download and extract them. Since 2.1 dev is no longer happening this seems fair imho.

dotarmin commented 6 years ago

Since 2.1 dev is no longer happening this seems fair imho.

I can agree with you, let check if somebody else from the community has some more input otherwise it seems fair enough because v2.1 is not developed any more just as you say.

Julusian commented 6 years ago

One question to look into is what happens to cloning and checking out commits if the lfs files are unavailable? The master branch has commits that use lfs back before we moved away from it. If I try to push it to my personal gitlab server with lfs disabled it refuses it with the error remote: GitLab: LFS objects are missing. Ensure LFS is properly set up or try a manual "git lfs push --all". I havent tested other git providers, so don't know if gitlab is an anomaly but even if it is it would be good for it to work there I need to do some more research but I suspect we may need to rewrite history again to completely remove lfs from the repo to fix that.

As for the proposed solution, I think that a seperate http zip to download is reasonable. However, I assume we would also need to purge lfs from the 2.0 branch and tags, do we want to do the same for those? An easier (although more confusing for users) solution which would also cover all of those would be to push the pre-lfs version of everything except 2.2 to a https://github.com/CasparCG/server-legacy repo where they can live on in their bloated form, and the https://github.com/CasparCG/server repo can have just the 2.2(master) branch and any future tags.