CasperDash / casperdash-extension

Casper blockchain wallet
https://casperdash.io
MIT License
6 stars 5 forks source link

[Extension] It show $0.03 when user doesn't have any CSPR #115

Closed gaupoit closed 2 years ago

gaupoit commented 2 years ago

Describe the bug

Screen Shot 2022-08-08 at 11 12 08

To Reproduce Steps to reproduce the behavior:

  1. Go to Home tab with zero balance
  2. See the 0.03$ in CSPR row

Expected behavior Should show 0

Screenshots N/A

Smartphone (please complete the following information):

Additional context N/A

duc-q commented 2 years ago

@gaupoit

I did a quick investigation on this issue and found out this:

The final price 0.03 comes from current_price, based on this request from https://api.coingecko.com/

image

That means we're showing the current market price of CSPR, not how much value User is owning the coin in current wallet.

Please help to recheck with @djhahe ,

Thanks

gaupoit commented 2 years ago

@gaupoit

I did a quick investigation on this issue and found out this:

The final price 0.03 comes from current_price, based on this request from https://api.coingecko.com/

image

That means we're showing the current market price of CSPR, not how much value User is owning the coin in current wallet.

Please help to recheck with @djhahe ,

Thanks

We have balance case. Screen Shot 2022-08-09 at 09 29 11