search

CasperTech / node-metaverse

A node.js interface for Second Life.
MIT License
50 stars 34 forks source link

Add RegionInfo5 to RegionInfoMessage #64

Closed callcolor closed 1 year ago

callcolor commented 2 years ago

Fixes "WARNING: Finished reading RegionInfoMessage but we're not at the end of the packet (154 < 183, seq 39)"

Fixes "TypeError: Cannot read properties of undefined (reading 'removeAttachment')"

Adds new Region properties. KRA8FUK

IAmNolanPerry commented 1 year ago

@TomMettam Can you review this please whenever possible, this is a pretty good fix for it, mainly for the fixing the Reading RegionInfoMessage

TomMettam commented 1 year ago

Done (Ignore previous comment, i misread something :P)

TomMettam commented 1 year ago

Note that this currently causes issues with OpenSim which doesn't support the extended message (yet).

IAmNolanPerry commented 1 year ago

Is that the only thing prohibiting this from being merged? What is the solution to this other than getting OpenSimulator Core to add support for this? I'm thinking making it be a switch or flag maybe that changes the params based on if it's SL or something else?

TomMettam commented 1 year ago

The message handler needs to be adjusted to be a bit more tolerant to missing data before I can merge this.

@callcolor can you please split out the ToS stuff into a different MR