search

CasperWA / voila-optimade-client

Import structures in AiiDA lab using OPTIMADE
MIT License
2 stars 6 forks source link

Use regular dropdown to check materials cloud sub-databases #433

Open unkcpz opened 2 years ago

unkcpz commented 2 years ago

The DropdownExtended is used to support the category of projects databases of materials cloud. It makes no too much sense which one should be General and which should be in Projects. Moreover, this widget cause issue such as https://github.com/CasperWA/voila-optimade-client/issues/369. Can we remove it and use regular dropdown widget, put all sub-databases parallelly?

What do you think? @CasperWA @csadorf

csadorf commented 2 years ago

This was specifically requested by Nicola. Maybe we can use a regular widget for now, but try to bring it back eventually?

unkcpz commented 2 years ago

But what is 'general' mean, why only CURATED covalent organic frameworks database?

csadorf commented 2 years ago

But what is 'general' mean, why only CURATED covalent organic frameworks database?

I would suggest you bring this up directly with him.

unkcpz commented 2 years ago

Okay, I will keep this issue open and put zero effort into this before the testing with Nicola.

CasperWA commented 2 years ago

While this is a MaterialsCloud-specific question you have raised, I will keep it here (not moving it to tools-optimade-client, where it otherwise belongs), due to the fact that the DropdownExtended widget is indeed implemented here.