search

CastXML / pygccxml

pygccxml is a specialized XML reader that reads the output from CastXML or GCCXML. It provides a simple framework to navigate C++ declarations, using Python classes.
Boost Software License 1.0
129 stars 44 forks source link

handle null comparison #107

Closed adeepkit01 closed 4 years ago

adeepkit01 commented 4 years ago

Fix mentioned in issue #56

Since None is a supported value for default_value but python 3 does not support None comparison, an exception is thrown in the above line.

This PR fixes that.

iMichka commented 4 years ago

Hi. Sorry for the delay.

I need to fix the CI first, I have not been working on this project for at least one year. Let me a few days to try to get this going.

Question: would you have a minimal c++ code example which triggers these lines. I think it would be great if we could add a test for these cases.

adeepkit01 commented 4 years ago

This is a simple example where this issue hits, do you have any suggestion on how to convert it into a test?

iMichka commented 4 years ago

I fixed the CI. Can you rebase this branch on develop to let it run again?

iMichka commented 4 years ago

Merged: I added a test here: e3c9a03128f6a5b52c95ca94b46310cbf70a331d, and made a small cleanup here: 4572c295e3d1c186287d9f25d79523bd3e312b8b

I will try to work on a 2.0.0 release, I want to review the other open pull requests. At least the change is now merged in the develop branch. Sorry for the delay.