search

CastXML / pygccxml

pygccxml is a specialized XML reader that reads the output from CastXML or GCCXML. It provides a simple framework to navigate C++ declarations, using Python classes.
Boost Software License 1.0
131 stars 45 forks source link

Add simple example Jupyter notebook (for Binder) #127

Closed EricCousineau-TRI closed 3 years ago

EricCousineau-TRI commented 4 years ago

Towards #126

Preview Link: https://mybinder.org/v2/gh/EricCousineau-TRI/pygccxml/feature-py-notebook-example?filepath=pygccxml/docs/examples/notebook/example.ipynb

tao558 commented 3 years ago

Just as a note: this looks good so far. I'll do another review and approve when the todos are gone

EricCousineau-TRI commented 3 years ago

Removed TODO about path stuff (I won't be able to investigate anytime soon).

Briefly trying the JupyterLab setup, but may descope that as well.

EricCousineau-TRI commented 3 years ago

JupyterLab does not work easily; will leave in TODO; breadcrumb commit: 608f224

I think the remaining TODOs can remain as they are.

@tao558 Might you have time to take a look?

tao558 commented 3 years ago

@EricCousineau-TRI I'll take a look ASAP

EricCousineau-TRI commented 3 years ago

FYI I changed requirements away from use a set literal which is then converted to a list. That operation is redundant when dict/set become order-preserving (Python 3.5, I believe?), and provides information loss in lower Python versions.

EricCousineau-TRI commented 3 years ago

Are you OK with me squashing the commits when merging?

Yup!

EricCousineau-TRI commented 3 years ago

Please squash-merge if that's an option. If not, I can squash myself since review is done.

tao558 commented 3 years ago

Thanks @EricCousineau-TRI! Good to finally get this merged.