search

CastXML / pygccxml

pygccxml is a specialized XML reader that reads the output from CastXML or GCCXML. It provides a simple framework to navigate C++ declarations, using Python classes.
Boost Software License 1.0
131 stars 45 forks source link

Add support for -std=c++17 & -std=c++2a flag #99

Closed praetorian20 closed 6 years ago

praetorian20 commented 6 years ago

gcc/clang C++ standard version flags now support the -std=c++17 & -std=c++2a flags, along with their "gnu" counterparts.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 92.638% when pulling 417add6e90413b2a54b3ed08ddb777c5c942cd3b on praetorian20:develop into 87b4e12d211b37b2225e632b2881c4531613d4d7 on gccxml:develop.

praetorian20 commented 6 years ago

The travis-ci failure is due to a setup issue, not the code change.

iMichka commented 6 years ago

The patch looks good. I am working on fixing the CI here: #98. Once this is done I'll have a closer look to your changes :)

praetorian20 commented 6 years ago

Thanks. I added some new is_cxx* functions but I don't think any other than is_cxx11* are actually used. So if you want I can delete the rest.

iMichka commented 6 years ago

I fixed the CI, you can rebase and force push this.

praetorian20 commented 6 years ago

I deleted all the unused is_cxx* functions. Let me know if that's OK, I can add them back in if you prefer.

praetorian20 commented 6 years ago

@iMichka, sorry to bother you, but if the patch looks OK, would you please consider merging and creating a release? It would save me the trouble of having to patch pygccxml locally.

praetorian20 commented 6 years ago

Hi @iMichka, any update on this?

iMichka commented 6 years ago

Hey, really sorry, got stuck with other projects. I really need to find more time to work on this next pygccxml release.

Could you add the is_cxx* functions back? They may not be used inside pygccxml, but they are not part of the API and somebody may have used them. If we want to remove them, they need to go through a deprecation cycle (with a deprecation warning in 2.0.0, and a removal in 2.1.0).

So please just add them back, thanks. Once this is done I will merge this right away.

praetorian20 commented 6 years ago

Done, added the functions back. I haven't added new is_cxx17 and is_cxx2a` functions because it would be nice to get rid of all the unused ones at some point.

iMichka commented 6 years ago

Thanks @praetorian20. I will be on vacation and without internet connection during the 2 next weeks. I hope I can work a little bit on pygccxml soon so that I can get this 2.0.0 release out.