CastagnaIT / plugin.video.netflix

InputStream based Netflix plugin for Kodi
MIT License
1.89k stars 258 forks source link

Ignore empty cast names #1664

Closed Falke-Design closed 6 months ago

Falke-Design commented 6 months ago

Check if this PR fulfills these requirements:

Types of changes

Description

Fixes: #1655

"Error TypeError: Actor: name property must not be empty" occurs.

This happens if the Cast has some empty entries. For example the movie Misfit:

{
   "Title":"Misfit",
   "Cast":[
      "Selina Mour",
      "Lion Wasczyk",
      "Lisa-Marie Koroll",
      "Jonathan Elias Weiske",
      "Vivien Wulf",
      "Meriel Hinsching",
      "",
      "Moritz Schirdewahn",
      "Simon Will",
      "Sylvie Meis"
   ],
...
Falke-Design commented 6 months ago

Attention while testing: the cache needs to be cleared else the info data will be not parsed again. And then the error will still occur grafik

CastagnaIT commented 6 months ago

take a look on my new PR solution opened, and take a look at the differences, also take in account that the "person" list is not used by "cast" only but from each REFERENCE_MAPPINGS value, so the change is more small and not require specifics additional for loop and data replacing as done here