CastagnaIT / plugin.video.netflix

InputStream based Netflix plugin for Kodi
MIT License
1.91k stars 260 forks source link

AddonSignals: call timeout - when you browse having a lot of items on my list (ARM) #716

Closed ffpp2003 closed 4 years ago

ffpp2003 commented 4 years ago

Bug report

Your Environment

Used Operating system:

Describe the bug

I'm trying to open Netflix on LibreElec and the error AddonSignals: call timeout

Expected behavior

Open Netflix without showing up the error AddonSignals: call timeout

Actual behavior

Opening Netflix generates the error AddonSignals: call timeout, and after pressing ok, exits Netflix

Steps to reproduce the behavior

  1. Turn on pc
  2. Open Netflix
  3. If Netflix takes a long time to load, probably, the error will show up

Possible fix

Optimize AddonSignals???

Debug log

The debug log can be found from this link: https://pastebin.com/Xpn6sMvW

I had the opportunity to reproduce the error two or three times in a row. Sorry if the log is too long, I don't know how to start a new one. (I'm new in GitHub and in log setup and log exporting, so, if I did something wrong, please, tell me how to do it right)

Additional context or screenshots (if appropriate)

Installation

Other information

Screenshots

CastagnaIT commented 4 years ago

@stevenhoving nice suggestion thanks! i can improve the addonSignal patch, tomorrow i will test to see if the timing result correct

EDIT: I took a closer look at the code but it is not usable

because using: waitForAbort(self.timeout / 1000) the code wait until the end without check nothing is not the purpose of this function, it is necessary to check at intervals if data has arrived

@risogolo i have no idea maybe some memory leakage somewhere, can happen when an operating system has been running for many many hours without any reboot

it's a good thing if it works now

risogolo commented 4 years ago

@stevenhoving nice suggestion thanks! i can improve the addonSignal patch, tomorrow i will test to see if the timing result correct

@risogolo i have no idea maybe some memory leakage somewhere, can happen when an operating system has been running for many many hours without any reboot

it's a good thing if it works now

nope the device did not work long time, I always installed your version, deleted log via ssh, reboot, erased cache of the addon , enabled log, logged error, disabled logging, so at least 6-7 iterations of this since we stated testing, not sure whether kodi api has some ability to show some progressbar when loading content of the netflix folders, please take this as feature suggestion, anyway THANK YOU VERY MUCH

CastagnaIT commented 4 years ago

Sorry, I'm a too tired right now...hard to understand, can you say me in few words if is it working now?

risogolo commented 4 years ago

Sorry, I'm a too tired right now...hard to understand, can you say me in few words if is it working now?

if youre talking to me, then yes it is working now, THANK YOU VERY MUCH again

ffpp2003 commented 4 years ago

I've completely lost track of this issue. How is it going? Are you, CastagnaIT, near to fixing this bug?

CastagnaIT commented 4 years ago

@franchetoxx read upper post https://github.com/CastagnaIT/plugin.video.netflix/issues/716#issuecomment-656303346

stevenhoving commented 4 years ago

@CastagnaIT may I assume that my suggestion doesn't work? tbh I didn't test it myself.

CastagnaIT commented 4 years ago

@stevenhoving no because waitForAbort block code execution: https://codedocs.xyz/AlwinEsch/kodi/group__python__monitor.html#ga9a1d271d0fddebee906abcda904e8249 we must have a loop to verify the incoming data

stevenhoving commented 4 years ago

@CastagnaIT yup your correct.

montvid commented 4 years ago

For all other users of this thread it would be appreciated to have an answer by updating with these (NF addon+addonSignal patched): plugin.video.netflix_1.6.1_20200709_t5_30timeout.zip script.module.addon.signals-0.0.5_patched.zip

Works very good so far on x86 64 libreelec usb2 stick. After REINSTALL don't forget to disable updates & reboot - after that you're golden.

moozhub commented 4 years ago

Hello @CastagnaIT ... I appreciate your efforts. I've been following along the thread like a fly on the wall. I tried your latest fixes that you suggested and unfortunately still experiencing the issue. I attached my log here: http://ix.io/2rmS

My kodi instance is running on a SSD if that makes any difference.

CastagnaIT commented 4 years ago

@moozhub your problem not concern this issue you are using Fedora 32 with Kodi 18 that is not more supported Read the "Notice" in Wiki install instructions

moozhub commented 4 years ago

@moozhub your problem not concern this issue you are using Fedora 32 with Kodi 18 that is not more supported Read the "Notice" in Wiki install instructions

Hmm, didn't really grasp that from that notice..not looking for anything "official" but I'll stick around to see if you have anymore solutions. Thanks.

CastagnaIT commented 4 years ago

there are no solutions, Fedora has started removing python 2

moozhub commented 4 years ago

python2 still exists in the repos, they may be phasing it out but it's probably not much different than the other users you're speaking with about this issue. The plugins are still using python2.

CastagnaIT commented 4 years ago

@moozhub sorry but i need to ask you to do not this Issue thread for your problem because is totally different

moozhub commented 4 years ago

@CastagnaIT Agreed.. I can open a new issue for you

risogolo commented 4 years ago

How is it going with fixing this ?

CastagnaIT commented 4 years ago

How is it going with fixing this ?

see comment https://github.com/CastagnaIT/plugin.video.netflix/issues/716#issuecomment-656303346

risogolo commented 4 years ago

How is it going with fixing this ?

see comment #716 (comment)

Yes I saw that, I meant permanent proper fix

CastagnaIT commented 4 years ago

to know the exact date for release of AddonSignals you have to ask to AddonSignals dev maintainer

risogolo commented 4 years ago

to know the exact date for release of AddonSignals you have to ask to AddonSignals dev maintainer

OK I will wait, Im not Python / Kodi developer. I dont know what AddonSignals is

MartChic commented 4 years ago

A new version of AddonSignals has been released. Is there anything to do to update it if we installed your patched version?

CastagnaIT commented 4 years ago

I don't see the official release yet, but I think it's almost ready when it will be released, if you already have the latest version of the NF addon, there is nothing else to do

i mean AddonSignals will be updated and overwrited by the new version that contains my patch

risogolo commented 4 years ago

I dont see any release yet for addon signals, Im confused, Im still using the version of netflix plugin that you built for "me". Can I start to use latest version or not? (will that version contain patch that you created for addon signals even if no official release of addon signals yet)

CastagnaIT commented 4 years ago

the dev of AddonSignals is still busy... yesterday i have tried to write to him to remember him to publish the new release

stevenhoving commented 4 years ago

@CastagnaIT I figured out what was wrong with my setup (I suffered from a lot of call timeouts). I had a really slow sd card in my rpi4. I switched to a 128GB Supersonic Rage Elite 3.1 usb stick. The difference in performance is night and day. So it might be a good advice to people who suffer from a lot of these timouts to change there storage type.

montvid commented 4 years ago

I changed to sata ssd + latest version of netflix addon and I don't see timeouts anymore. Storage has a big impact.

CastagnaIT commented 4 years ago

@stevenhoving is already mentioned in the most frequent cases in the wiki https://github.com/CastagnaIT/plugin.video.netflix/wiki/FAQ-%28Errors%29#addon-signals-call-timeout

stevenhoving commented 4 years ago

@stevenhoving is already mentioned in the most frequent cases in the wiki https://github.com/CastagnaIT/plugin.video.netflix/wiki/FAQ-%28Errors%29#addon-signals-call-timeout

Thanks... now I kind of look like an idiot 😄. I should have consulted the wiki.

xLAva commented 4 years ago

My pull request #884 fixes the issue for sd cards by disabling the caching on disk and removing the art cache completely. It is super fast now on my rpi4 even with just an sd card.

CastagnaIT commented 4 years ago

@risogolo I think you have already seen the new addon signals release is out

risogolo commented 4 years ago

nope I havent, I will try to update plugin to the latest version tonight, thank you