Implement simple source

CasualX / pelite

Lightweight, memory-safe, zero-allocation library for reading and navigating PE binaries.

MIT License

280 stars 42 forks source link

Implement simple source #245

Closed tathanhdinh closed 3 years ago

tathanhdinh commented 3 years ago

Hello,

The PR

removes description from Error since the method is deprecated now,
adds a trivial `source

CasualX commented 3 years ago

Thanks for taking your time to make a PR!

The changes you suggest while technically correct aren't substantive enough to include.

Removing description is technically a breaking change and it doesn't hurt anyone by being there. Just implementing it doesn't appear to cause any deprecation warnings so I don't think it's a good idea to remove at this time.

Adding a source method isn't necessary as the default implementation already returns None.