search

CasuallyCalm / discord-pretty-help

An embed version of the built in help command for discord.py
MIT License
127 stars 32 forks source link

Update pretty_help.py #79

Closed Kolhax closed 2 years ago

Kolhax commented 2 years ago

Just added a feature for Image / Thumbnail in DefaultCommand image

CasuallyCalm commented 2 years ago

I like this idea but I think it could be simplified by adding self.image and self.thumbnail as optional properties to Paginator then setting the image and thumbnail either in _new_page() or _add_page() instead of adding args to the other functions.

I'm also working on v2 so if you want to add a PR to that fork instead that would be better.

Kolhax commented 2 years ago

it's kinda just what I just did...

CasuallyCalm commented 2 years ago

Kind of, but you changed more than what needed to be changed to make this work. Please make the changes above and PR on v2. Thanks!