search

Casvt / Kapowarr

Kapowarr is a software to build and manage a comic book library, fitting in the *arr suite of software.
https://casvt.github.io/Kapowarr/
GNU General Public License v3.0
463 stars 20 forks source link

[Bug] New books being added as TBP #108

Closed JaredVanderford closed 11 months ago

JaredVanderford commented 11 months ago

Description of the bug The logic for determining if a volume is TPB appears to just be if the issue count = 1. While this likely works for older books, as new volumes are released and added, the volume is being flagged as a TPB when it's a normal ongoing series. The volume info is not updating as more issues are released, and because the volume is flagged as a TPB it is not matching issues correctly on the auto search.

To Reproduce

  1. Go to 'Add volume'
  2. Search for a new series (as of this date Spider-Woman has a new volume)
  3. Add volume with only 1 current issue.
  4. Go to home page.
  5. Navigate to newly added volume, see it is flagged as TPB
  6. Wait till more issues are released
  7. When more issues are released, see that the TPB special issue flag is not removed from the volume.
  8. Manually search for new issue.
  9. See match failure due to special version conflict.

Expected behaviour Either not flagging new ongoing series as TPB, or if that is unavoidable due to lack of metadata, when new issues are added to the volume, remove the TPB flag to allow for issue matching.

Screenshots TPB screenshot 2 TPB screenshot 1

Version info Kapowarr version v1.0.0-beta-3 Python version 3.8.17.final.0 database version 10 Windows 11 Pro Hosted on Docker Brave Version 1.60.118

Additional context Looking at the dev branch, the logic for setting TPB is in volumens.py lines 66-67

Casvt commented 11 months ago

Ah okay sounds logical. Kapowarr should re-evaluate the special version when updating the issue list. You'll still have that it'll be considered a TPB for the time that it has only 1 issue, but can't do much about that. I can't know if in the future a second issue is released after all. Just re-evaluating it every issue update should suffice.

Casvt commented 11 months ago

Fixed in commit c2a946632e48014a3796c6e731367f1895af8af1