CatBlock / catblock

CatBlock - An ad-blocking extension (with an ability to replace ads by pictures) for all major desktop browsers!
https://getcatblock.com
GNU General Public License v3.0
95 stars 44 forks source link

Address Firefox review #130

Closed itskdog closed 7 years ago

itskdog commented 7 years ago

1) We generally don't accept using the 'eval' function. There are many reasons not to use 'eval', and there are alternatives available. You can read more about it here: https://developer.mozilla.org/en/XUL_School/Appendix_C:_Avoid_using_eval_in_Add-ons

2) Please use non-custom versions of jquery-ui, as well as the stock version of jquery, that match the checksums in https://github.com/mozilla/amo-validator/blob/master/validator/testcases/hashes-allowed.txt

3) Your CSP allows various unsafe operations including remote script execution. Please remove the unsafe-* values and find alternatives for your source code.

tomasko126 commented 7 years ago

1 is being addressed in #123, I will take a look at other issues asap.