CatBlock / catblock

CatBlock - An ad-blocking extension (with an ability to replace ads by pictures) for all major desktop browsers!
https://getcatblock.com
GNU General Public License v3.0
95 stars 44 forks source link

Button popup cannot open dialogue box on page in Firefox #157

Open zhum opened 7 years ago

zhum commented 7 years ago

Note: I use localized interface, so may be menu point can ba named slightly different. Note 2: seems to be related to BUG#153

  1. Go to any page, e.g. https://www.mendeley.com/newsfeed
  2. Click to CatBlock icon, select "Do not run on this domain pages"
  3. Reload page.

What should happen when you do the above steps

This page and all pages on this domain should be "whitelisted" and CatBlock shouldb't block any requests on them.

What actually happened?

CatBlock works as nothing happened, all block applied.

Do you have any other comments? If you can, can you please attach a screenshot of the bug?

If I manually add this domain in whetelist via Settings, all work as expected.

--- The questions below are optional but VERY helpful. ---

If unchecking all filter lists fixes the problem, which one filterlist must you check to cause the problem again after another restart?

no

Technical Chrome users: Go to chrome://extensions ->Developer Mode -> Inspect views: background page -> Console. Paste the contents here:

I use FF on Linux x86-64 (Mint 18.3)

itskdog commented 7 years ago

Thanks for this report - I kept forgetting to make one myself!

It's not related to #153, though.

What should happen is that a box pops up allowing you to select how much of the domain you want to block, but that's not appearing at the moment.

It seems to work fine on Chrome, but I'll take a look at this.

Thanks once again!

itskdog commented 7 years ago

Bug confirmed with latest unpublished version in Firefox Unbranded 56.

itskdog commented 7 years ago

@tomasko126 I've tried taking a look - I'm getting an error in the background page "Can't access dead object" at js/background.js:1175. The debugger wouldn't load for me in Firefox Unbranded 56.0.2