Fixes multiple occurrences of looking for :shortcode: in the database, preventing Undo activities to be processed.
Added handling for Undo with Misskey reactions.
Fixes an issue where me was true when a remote reaction had the same shortcode as an already present reaction.
Added custom_emoji to reacted? to be able to differentiate between reactions with the same shortcode but different emojis.
Don't know if you were already working on this or not, but I thought I offer my solution.
Some of it could probably be optimised, but I worked multiple days on this and I'm tired.
Outstanding issues:
Because reactions from the same account with the same name, but different custom emojis can exist, it is possible for sidekiq to throw:
ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR: duplicate key value violates unique constraint "index_status_reactions_on_account_id_and_status_id"
for remote reactions and Duplicate record for local reactions.
Fixes multiple occurrences of looking for
:shortcode:in the database, preventingUndoactivities to be processed. Added handling forUndowith Misskey reactions. Fixes an issue wheremewas true when a remote reaction had the same shortcode as an already present reaction. Addedcustom_emojitoreacted?to be able to differentiate between reactions with the same shortcode but different emojis.Don't know if you were already working on this or not, but I thought I offer my solution. Some of it could probably be optimised, but I worked multiple days on this and I'm tired.
Outstanding issues: Because reactions from the same account with the same name, but different custom emojis can exist, it is possible for sidekiq to throw:
for remote reactions and
Duplicate recordfor local reactions.