search

CatalogueOfLife / backend

Complete backend of COL ChecklistBank
Apache License 2.0
15 stars 11 forks source link

Allow catalogueKey param when using USAGE_ID param #1149

Open thomasstjerne opened 2 years ago

thomasstjerne commented 2 years ago

Related to https://github.com/CatalogueOfLife/checklistbank/issues/1054 - if the workbench should still work properly, the catalogueKey should still be allowed. Otherwise it would not be possible to search for a set of USAGE_IDs thats has no decisions already.

Request failed with status code 400
Invalid search request. No filters besides dataset key allowed when specifying usage ID

https://api.checklistbank.org/dataset/1101/nameusage/search?USAGE_ID=xBM3&USAGE_ID=Chironomidae-%5BAblabesmyia%5D-aurea-ae5ef00b3&USAGE_ID=Chironomidae-%5BAblabesmyia%5D-caliptera-53f4adbbb&USAGE_ID=Chironomidae-%5BAblabesmyia%5D-eggeri-562bf4f1a&USAGE_ID=Chironomidae-%5BAblabesmyia%5D-limbata-b86af2d55&USAGE_ID=Chironomidae-%5BAblabesmyia%5D-miki-562bf4f1a&USAGE_ID=Chironomidae-%5BAblabesmyia%5D-pectinata-07d20aeaf&USAGE_ID=Chironomidae-%5BAblabesmyia%5D-pseudornata-d92dd0279&USAGE_ID=Chironomidae-%5BAblabesmyia%5D-quadrinotata-b86af2d55&USAGE_ID=Chironomidae-%5BAblabesmyia%5D-rubicundulus-d92dd0279&catalogueKey=3&facet=rank&facet=issue&facet=status&facet=nomStatus&facet=nameType&facet=field&facet=authorship&facet=authorshipYear&facet=extinct&facet=environment&facet=origin&limit=50&offset=0

mdoering commented 2 years ago

Puh, there was a reason why that is checked. I can remove the constraint, but the search will then probably not behave as expected. For applying new decisions we can maybe live with incorrect filtering? Instead of removing the constraint I could add a new parameter that would turn the check off, sth like experimental=true or unsafe=true. Would that help?

thomasstjerne commented 2 years ago

Lets try without it - but I reckon it would show decisions for any project?

mdoering commented 2 years ago

I have added the unsafe=true parameter so you can add catalogueKey etc. Decisions shown should be correct, just other filtering like names without decisions only might be wrong.