CatalogueOfLife / backend

Complete backend of COL ChecklistBank
Apache License 2.0
15 stars 11 forks source link

Issue to detect names without authorities in CLB datasets #1282

Open DianRHR opened 1 year ago

DianRHR commented 1 year ago

There are several datasets in CLB that have names without authority, but this is not detected in any of the issues of ChecklistBank. In some datasets, any of the names have authority, in some other ds some names have author, some don't. Here are examples of both cases.

Example: https://www.checklistbank.org/dataset/2013/classification?taxonKey=x44

image

image

Example (some names have authority, some don't) : https://www.dev.checklistbank.org/dataset/34048/classification?taxonKey=xD

image

Not detected in CLB issues: https://www.dev.checklistbank.org/dataset/34048/issues

DianRHR commented 1 year ago

This is an important issue to consider on weighing issues to filter ds for the XCOL release

mdoering commented 1 year ago

I wonder how to best be able to filter for names with or without authorship. Options to consider:

  1. allow negating search filter for name fields
  2. divide NameType=SCIENTIFIC into 2 - one with, one without authorship. That would allow to filter on searches, fitler on sector syncs and report in metrics.
  3. flag names without authorship as an informative (green) issue. This works well for external datasets, but issues are not always created automatically for every name, e.g. currently not for projects. But it is sth we want to do for all names in the future.
DianRHR commented 1 year ago

Agree on 1 and 2.
Not sure in 3, because we are considering warning and error issues in weighing to filter . Probably it's better to flag this issue as warning (yellow), also because of the importance of authors for the homotypic grouping.

mdoering commented 1 year ago

There is nothing wrong in giving names without an authorship. I would not think we should flag a warning. I tend to prefer 2 at this stage