CatalogueOfLife / backend

Complete backend of COL ChecklistBank
Apache License 2.0
15 stars 11 forks source link

CLB: Unable to apply Complex Decisions #1309

Closed yroskov closed 6 months ago

yroskov commented 6 months ago

For @mdoering attention:

Working with Unparsable Authorship (42 names) in SF Lygaeoidea (id 1173), I was no able to edit authorstrings (i.e. delete star symbol). All decisions which I applied are not shown in the report/interface here:

https://www.checklistbank.org/catalogue/3/dataset/1173/workbench?facet=rank&facet=issue&facet=status&facet=nomStatus&facet=nameType&facet=field&facet=authorship&facet=authorshipYear&facet=extinct&facet=environment&facet=origin&issue=unparsable%20authorship&limit=100&offset=0

image

yroskov commented 6 months ago

FireFox console, if it may help:

image

mdoering commented 6 months ago

This is the workbench - we only fixed caching decisions in the duplicate view

mdoering commented 6 months ago

The cached API call is URL: https://api.checklistbank.org/dataset/1173/nameusage/search?catalogueKey=3&facet=rank&facet=issue&facet=status&facet=nomStatus&facet=nameType&facet=field&facet=authorship&facet=authorshipYear&facet=extinct&facet=environment&facet=origin&issue=unparsable%20authorship&limit=100&offset=0

the catalogueKey is the problem. When set I will make sure caching is off

mdoering commented 6 months ago

gonna be deployed in ~1h

mdoering commented 6 months ago

@yroskov sorry, its getting to late for today. The build still takes an hour. Doing this early tomorrow instead

mdoering commented 6 months ago

deployed and works for me

yroskov commented 6 months ago

Thank you, @mdoering ! It works for me too. But the fix caused another problem: all 3 buttons "With decision", "Without decision" & "All" show now a list "Without decision" only https://www.checklistbank.org/catalogue/3/dataset/1173/workbench?facet=rank&facet=issue&facet=status&facet=nomStatus&facet=nameType&facet=field&facet=authorship&facet=authorshipYear&facet=extinct&facet=environment&facet=origin&issue=unparsable%20authorship&limit=100&offset=0

image

mdoering commented 6 months ago

Can you give me an example link where the same results are shown? The link above returns no results at all for me in all 3 cases. And if I remove the issue filter I get 3 different results for with/without/all decisions as expected:

https://www.checklistbank.org/catalogue/3/dataset/1173/workbench?facet=rank&facet=issue&facet=status&facet=nomStatus&facet=nameType&facet=field&facet=authorship&facet=authorshipYear&facet=extinct&facet=environment&facet=origin&limit=100&offset=0

yroskov commented 6 months ago

"the same results are shown" means that all names now have got decisions. During my work, I have seen that list become shorter and shorter after application of decisions and window refresh - up to the 0 results. I would expect that list "With decision" will show all names with applied decisions, but today it was not happened - the same 0 results.

I'll put here a link to the same problem, as soon as I meet it again.