CatalogueOfLife / backend

Complete backend of COL ChecklistBank
Apache License 2.0
15 stars 11 forks source link

Use usage labels in AC Exports - CoL+ spoils authorstrings #595

Closed yroskov closed 4 years ago

yroskov commented 4 years ago

Please compare original authorstring presentation in FishBase taxa: Aphyosemion calliurum ahli (non Myers, 1933) | misapplied name for Aphyosemion herzogi Radda, 1975 | FishBase Aphyosemion calliurum ahli (non Myers, 1933) | misapplied name for Fundulopanchax gardneri (Boulenger, 1911) | FishBase Aphyosemion calliurum ahli Myers, 1933 | synonym for Aphyosemion ahli Myers, 1933 | FishBase http://www.catalogueoflife.org/annual-checklist/2019/search/all/key/Aphyosemion+calliurum+ahli/fossil/1/match/1

and presentation after CoL+ transformations: Aphyosemion calliurum ahli | misapplied name for Aphyosemion herzogi Radda, 1975 | FishBase Aphyosemion calliurum ahli | misapplied name for Fundulopanchax gardneri (Boulenger, 1911) | FishBase Aphyosemion calliurum ahli Myers, 1933 | synonym for Aphyosemion ahli Myers, 1933 | FishBase http://workbench.catalogueoflife.org/col_plus/search/all/key/Aphyosemion+calliurum+ahli/fossil/1/match/1

It would be better, if CoL+ do no take off any parts in authorstrings. Expected behavior: Identified issues in authorstrings should be reported to GSD authors and editors for their decisions.

Another example of CoL+ problems with authorstrings is automatic exclusion of names with "ined." and "comb. ined." portions in authorstrings. These issues should be reported, but not modified without editorial decision.

mdoering commented 4 years ago

These are not removed really, just parsed into different parts. Taxon concept phrases like the one for misapplied names, e.g. "non XYZ" are found in the API in accordingTo and rendered in the CoL+ UI.

Bildschirmfoto 2019-12-18 um 20 51 51

I take this as a bug to fix the export!

yroskov commented 4 years ago

Authorstrings are empty in a product.

yroskov commented 4 years ago

It is wrong to remove (non Myers, 1933) from the authorstring, because it says a lot to taxonomists.

mdoering commented 4 years ago

The manuscript name exclusion is done deliberately and you agreed with it: https://github.com/Sp2000/colplus-backend/issues/350

@yroskov If you don't want that anymore we can easily remove the automatic filtering again. It's done on purpose to avoid excessive manual decisions. There is no point in manually removing all of them. Either they all stay in or all are out. Or what would be the reasoning for deciding on manuscript names case by case?

yroskov commented 4 years ago

All cases of manuscript names are different. There are about 500 provisionally proposed names in WCSP, WPlants & WFerns. GSD authors intended to present consistent classification based on modern data. We must not simply delete all these species without asking authors first.

mdoering commented 4 years ago

please reopen the issue above and explain your expected behavior instead if you want that to be changed

yroskov commented 4 years ago

done: #269

mdoering commented 4 years ago

blocked by #598

mdoering commented 4 years ago

we are using verbatim authorships in the export now, so not blocking milestone anymore