CatalogueOfLife / checklistbank

UI for checklistbank.org
https://www.checklistbank.org/
6 stars 2 forks source link

Why is source logo URL wrong in XRelease? #1286

Closed mdoering closed 9 months ago

mdoering commented 9 months ago

The source of an XRelease which existed already in the main release fetches the source logo from a wrong URL using the main release logo: https://api.dev.checklistbank.org/dataset/265693/logo?size=MEDIUM see https://www.dev.checklistbank.org/dataset/265693/taxon/8M66

The taxon does include a sectorKey which resolves to a proper sector in the release: https://api.dev.checklistbank.org/dataset/265693/sector/1517

However a taxon from a merge sector source does use this URL: https://api.dev.checklistbank.org/dataset/2144/logo see https://www.dev.checklistbank.org/dataset/265693/taxon/c4adc70b-4a7a-482f-aa1e-5c7a5f7d6265

This works, but uses the live datasets logo which might change over time. @thomasstjerne logos are archived for each release and the UI should access them like this for all (x)release sources:

/dataset/{releaseKey}/logo/source/{sourceDatasetKey} See https://github.com/CatalogueOfLife/backend/issues/1245