CatalogueOfLife / checklistbank

UI for checklistbank.org
https://www.checklistbank.org/
6 stars 2 forks source link

CLB: seems, **Apply Complex Decisions** does not work #1287

Open yroskov opened 9 months ago

yroskov commented 9 months ago

I am trying to resolve ISSUE Multi Word Epithet in World Plants:

https://www.checklistbank.org/catalogue/3/dataset/1141/workbench?facet=rank&facet=issue&facet=status&facet=nomStatus&facet=nameType&facet=field&facet=authorship&facet=authorshipYear&facet=extinct&facet=environment&facet=origin&issue=multi%20word%20epithet&limit=100&offset=0

I did apply follow corrections via Apply Complex Decisions to the synonym Gamanthera van der Werff, parsed as a species with incorrect authorship : Was: image

Corrected as: image

Decision saved.

Decision was not applied after screen reload:

image

mdoering commented 9 months ago

Why does it not work?

I can find the decision and it looks just right to me:

image

Remember a decision is only applied on sync, not afterwards or when you create it. The only thing I can see in aboves screenshot is the extra space after the genus name in the sciname - we should trim that in the backend.

Have you resynced the sector afterwards?

yroskov commented 9 months ago

Why does it not work?

(For attention of @thomasstjerne )

Because, user interface does not show that decision is established successfully. Decision column is empty:

image

https://www.checklistbank.org/catalogue/3/dataset/1141/workbench?facet=rank&facet=issue&facet=status&facet=nomStatus&facet=nameType&facet=field&facet=authorship&facet=authorshipYear&facet=extinct&facet=environment&facet=origin&issue=multi%20word%20epithet&limit=100&offset=0

yroskov commented 9 months ago

This is newly introduced bug.

Examples of expected interface behaviour from previous assemblies:

image

yroskov commented 9 months ago

@thomasstjerne, it turns as a global [interface?] bug through all ISSUES and TASKS reports:

(I did apply status "Provisionally Accepted" to 134 names in the report, and decision labels didn't appear in the column Decision after a reload of the browser page)

image

https://www.checklistbank.org/catalogue/3/dataset/1141/workbench?decisionMode=_NULL&facet=rank&facet=issue&facet=status&facet=nomStatus&facet=nameType&facet=field&facet=authorship&facet=authorshipYear&facet=extinct&facet=environment&facet=origin&limit=500&nomstatus=manuscript&offset=0&reverse=false&status=accepted

thomasstjerne commented 9 months ago

If you have the filter "without decision" on, they will actually disappear because they are no longer in the search criteria when the decision is applied. Is this a possible explanation?

thomasstjerne commented 7 months ago

I think we have a problem with decisions getting out of sync between the DB and Elastic. Probably related to this one: https://github.com/CatalogueOfLife/checklistbank/issues/1310