CatalogueOfLife / checklistbank

UI for checklistbank.org
https://www.checklistbank.org/
6 stars 2 forks source link

Bug: "parsed" flag in reference set to "true" even when reference has not been parsed #1406

Closed rdmpage closed 1 month ago

rdmpage commented 1 month ago

Description

A reference can have parsed set to true when it hasn't been parsed. For example https://api.checklistbank.org/dataset/1051/reference/16269 returns:

{
  "created": "2022-10-20T15:09:42.301187",
  "createdBy": 10,
  "modified": "2022-10-20T15:09:42.301187",
  "modifiedBy": 10,
  "datasetKey": 1051,
  "id": "16269",
  "verbatimKey": 16362,
  "csl": {
    "id": "16269"
  },
  "citation": "Roth, L.M. (1999) New cockroach species, redescriptions, and records, mostly from Australia, and a description of Metanocticola christmasensis gen. nov., sp. nov., from Christmas Island (Blattaria). Records of the Western Australian Museum, 19(3), 327–364.",
  "parsed": true
}

If the reference had, in fact, been parsed, I would have expected csl to be more than simply {"id": "16269"}.

What browsers are you seeing the problem on?

No response

ChecklistBank URL

No response

mdoering commented 1 month ago

Fully agree. The flag is currently set when there is some csl present at all. Hm, rather difficult to judge when some reference is parsed. I have changed it to require at least a title, author or containerTitle. Still not great, but better than any CSL