search

Catalysts / cat-angular

Basic support for Angular Apps
Apache License 2.0
7 stars 16 forks source link

Add i18n for tab names #39

Closed mangei closed 8 years ago

mangei commented 9 years ago

I saw that there is already a solution for that. we need to check which one is better.

tsalzinger commented 9 years ago

the current solution utilizes the cat-i18n directive and creates a unique key for each tab (including all relevant parent names) and follows the same structure as i18n does everywhere else in cat-angular atm

your solution creates non unique tab keys by default, which has certain drawbacks

the one thing your solution has that the current one doesn't is the support for the translation key to be specified in the tab config, but this could easily be achieved as well with the current solution when we just pass the whole tab object to getTabKey instead of only the tab name

mangei commented 9 years ago

@cat-davidhangl please evaluate your solution with the current one in cat-angular (see fe399950 and 3b49893) and give me some instructions, how to proceed. Thanks! (of course you can also do it by yourself, just give me a note)

tsalzinger commented 8 years ago

closing for now, please open a new PR or issue when you have decided on how to proceed