Fix configuration for lint-staged

CatchTheTornado / askql

AskQL is a query language that can express any data request

https://askql.org/

MIT License

387 stars 27 forks source link

Fix configuration for lint-staged #221

Open czerwinskilukasz1 opened 4 years ago

czerwinskilukasz1 commented 4 years ago

Following this comment thread, prettier and eslint shouldn't fail on unsupported file extensions. We should review our configuration for these tools in lint-staged.

czerwinskilukasz1 commented 4 years ago

@km4 , would you like to take a look?

mhagmajer commented 4 years ago

Let's solve this issue with the configuration of these respective tools. Maybe the way we run prettier in the CI doesn't read prettier.config.js? If you want to go ahead with this quick fix, could you also create a bug issue to fix it in the right place?

km4 commented 4 years ago

Look at after my work

km4 commented 4 years ago

@czerwinskilukasz1 can you paste the output from lint-staged? I switch to your branch, change to default rules on lint-staged ("*"), and all were passed correctly.

husky > pre-commit (node v12.14.1)
✔ Preparing...
✔ Running tasks...
✔ Applying modifications...
✔ Cleaning up...
[issue_182__playground_editor

@mhagmajer have some problems with lint-staged?

czerwinskilukasz1 commented 4 years ago

The issue was handing .handlebars file:

I submitted an issue to prettier, it's open so far: https://github.com/prettier/prettier/issues/8631