search

CatchTheTornado / askql

AskQL is a query language that can express any data request
https://askql.org/
MIT License
387 stars 27 forks source link

Playground: Should we use Monaco Editor, Ace Editor or another one? #236

Closed czerwinskilukasz1 closed 4 years ago

czerwinskilukasz1 commented 4 years ago

Please see comment on editor at:

  1. https://github.com/xFAANG/askql/issues/108
  2. https://github.com/xFAANG/askql/issues/182
czerwinskilukasz1 commented 4 years ago

Blocks #184

czerwinskilukasz1 commented 4 years ago

TODO: answer to mhagmajer's: https://github.com/xFAANG/askql/issues/182#issuecomment-646974197

czerwinskilukasz1 commented 4 years ago

OK, so the strength of Monaco is much better and smarter autocomplete: image

The drawback of Monaco is that it doesn't work on mobile phones.

I thought the second drawback is that Monaco uses a different syntax coloring method from VS Code and multiple sources (1, 2 ) say they're not compatible nor translatable, so we would need to write syntax coloring twice, while Ace has a tool which helps translate VS Code syntax coloring to Ace's coloring (both are based on Textmate grammars).
However, you mentioned a converter written in 2019 which converts VSCode (Textmate) grammar to Monaco (Monarch) grammar. Not sure how well it works but I guess it's worth a try.

Assuming the converter works reasonably well, the question is: Better and smarter autocomplete OR Mobile phone support

czerwinskilukasz1 commented 4 years ago

Mobile phone support is not that important, so we choose Monaco editor. FYI @mhagmajer