CategoricalData / hydra

Transformations transformed
Apache License 2.0
72 stars 10 forks source link

Unify Name and FieldName, and make them aliases for string #121

Closed joshsh closed 2 months ago

joshsh commented 7 months ago

Hydra's Name and FieldName types are currently newtypes which wrap string. The fact that they are newtypes rather than type aliases adds complication to the codebase (particularly in Java) for little gain. Literally any string is valid as a type name, element name, field name, type variable, or term variable, though domain-specific encodings may impose their own constraints. Furthermore, the roles of Name and FieldName are more interchangeable now than they were when Hydra Core was first written. Let's just turn them both into a single typedef, Name.

joshsh commented 7 months ago

Note: depends on #70.