Catfriend1 / syncthing-android

Syncthing-Fork - A Syncthing Wrapper for Android.
Mozilla Public License 2.0
1.2k stars 40 forks source link

Forced run - split head, make clear "UI" vs. "daemon" #1040

Open licaon-kter opened 9 months ago

licaon-kter commented 9 months ago

...forced start is not doing what's expected, the UI messages are confused/ing.

1.26.0.2 F-Droid

The Status UI page says: "Syncthing is not running" and lower "reason: Syncthing is running because you forced it to start regardless..."

No sync happens though.

188a1c25_C5ujqPtHSyqY6G8Cp3qx7g

To fix it I need to exit it, then restart it.

licaon-kter commented 9 months ago

Attached picture to OP

Catfriend1 commented 9 months ago

@licaon-kter

Is the screenshot above the result of the native crashing? This was reported since v1.26.x releases and upstream has merged a PR to fix this, hopefully to be released soon. I agree the messages are weird, but regarding that the native crashing should not be daily matter, I suggest it's okay.

The message "Syncthing is not running" is sent by the native executor which also detects the crash. The message in the "reason" section is just to sum up the set run conditions. Confusing yes, but at least we now know why it is ;-).

Maybe we could hide the reasons if a crash was detected.

licaon-kter commented 9 months ago

I don't see visible Android crashes, so if it's the daemon under the hood I'd need to check logcat.

licaon-kter commented 9 months ago

oh so you have in app logging, will capture one of those when it happens again (of course I tried now and it didn't crash)

fyi, when testing before, I needed to press restart or kill 2-3 times until it actually was able to start :(

Catfriend1 commented 9 months ago

@licaon-kter you could also try the latest preview build from the github release page . It contains upstream's fix.

EuPhobos commented 9 months ago

After last update this also happens to me too. Syncthing-fork not working anymore for me. Even if device on AC.

Catfriend1 commented 9 months ago

@EuPhobos try preview?

EuPhobos commented 9 months ago

@Catfriend1 yep, trying this file com.github.catfriend1.syncthingandroid_github_v1.26.1.0_2ee4de2c.apk, same problem. Before i has f-droid version running fine, today i update app and faced with a this problem. I export settings, remove f-droid verion, install github version, import settings - same problem. I can provide logs, if you need.

Catfriend1 commented 9 months ago

@EuPhobos

There is a newer release 1.27.0.0

EuPhobos commented 9 months ago

@Catfriend1 Oh, my inattention. 1.27 work fine now. Thank you very much! You're best

Catfriend1 commented 9 months ago

Thanks for reporting back

Catfriend1 commented 9 months ago

I think this is okay for me, let the head split when the native crashes. If this ever happens, the user is doomed and other parts of the app may also be inaccurate or non-working.

Catfriend1 commented 9 months ago

For correctness: it gets a verified bug label 😊

licaon-kter commented 9 months ago

let the head split when the native crashes.

No problem with that, maybe rework the strings a bit to separate "UI" vs "daemon" so they don't both identify themselves as "Syncthing"?