search

Catfriend1 / syncthing-android

Syncthing-Fork - A Syncthing Wrapper for Android.
Mozilla Public License 2.0
1.2k stars 40 forks source link

i18n: Remove XML entity for docs URL #1052

Closed acolomb closed 9 months ago

acolomb commented 9 months ago

The &folder_ignore_delete_docs_url; entity is used to avoid repeating the URL verbatim in translations strings. While this is a good approach in principle, it does come with a couple of drawbacks:

  1. Automated processing via XSLT (such as #1051) will resolve the entity refs automatically, this cannot be easily avoided.

  2. It is a one-off pattern, used only for this URL. All others are part of the translation strings verbatim. If used stand-alone, they are marked translatable="false".

  3. It is still error-prone to typos when making the translation. If the URL is screwed up, it won't get the user to its target. But if the entity reference is misspelled, there will be nothing to look at probably.

Any possible benefits don't outweigh these and the added complexity, thus get rid of the entity references (using a simple XSLT transform).

acolomb commented 9 months ago

Note that this will lead to conflicts when merging #1033 in advance. I suggest the following merge order, and will fix any upcoming conflicts ASAP (already done locally).

  1. 1053

  2. 1033

  3. 1051

  4. This, #1052

And as of this writing, Hosted Weblate has some troubles with losing the git remote repo connection every night, leading to alerts. I've contacted their support about it, trying not to touch anything in the meantime so they can troubleshoot.

acolomb commented 9 months ago

Weblate issue should be fixed.