search

Catfriend1 / syncthing-android

Syncthing-Fork - A Syncthing Wrapper for Android.
Mozilla Public License 2.0
1.93k stars 57 forks source link

Why is the "github" variant of Syncthing-Fork debuggable? #1122

Closed FixItKit closed 2 months ago

FixItKit commented 2 months ago

Being debuggable hurts performance so why is Syncthing-Fork's "github" variant debuggable? Does it being debuggable have any benefits?

Catfriend1 commented 2 months ago

Hi,

I have never thought about this, honestly. I think this was the case since the original app's time before forking it. For me its totally fine if it outputs the logcat lines. How can we turn it off?

I am not sure if the performance issues you see a result of the package being debuggable.

FixItKit commented 2 months ago

Hi,

I have never thought about this, honestly. I think this was the case since the original app's time before forking it. For me its totally fine if it outputs the logcat lines. How can we turn it off?

I am not sure if the performance issues you see a result of the package being debuggable.

I tested both versions and the non-debuggable Google Play Store version felt faster. Try navigating inside settings for example. I have tested other debuggable apps and it's the same for them.

FixItKit commented 1 week ago

@Catfriend1 https://medium.com/specto/dont-run-benchmarks-on-a-debuggable-android-app-like-i-did-34d95331cabb

Catfriend1 commented 1 week ago

Just use the F-Droid version, it's a release flavour.