Catherine808 / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

Summary: Grade = Meets Expectations #3

Open jordanwillis opened 6 years ago

jordanwillis commented 6 years ago

Overall you did a great job on this project! Despite not being able to see the images included on the page, everything else looked great. You did an especially nice job on your responsive design and the page correctly rendered the various mobile component versions when I resized the page.

I also liked your use of semantic HTML by using header, nav, and footer elements. If you are up for it, I would challenge you to replace some of your other more generic <div>'s with more specific elements that are also available such as section or main.

Your CSS looks really good as well. As you continue practicing creating stylesheets always keep the DRY (don't repeat yourself) principle in mind to ensure that you eliminate duplicated properties and styles.

Keep up the good work!