search

CatimaLoyalty / Android

Catima, a Loyalty Card & Ticket Manager for Android
https://catima.app
GNU General Public License v3.0
878 stars 151 forks source link

[Feature Request] SVG image/logo support #1142

Open wedebe opened 1 year ago

wedebe commented 1 year ago

I've been able to manually convert all of my card's logos from fandom's SVG image format, but myyyyy worrrrd it took forever!

Would it be possible to have Catima load and convert svg to png? Preferably with a fallback background colour (perhaps white, unless the logo itself is white on transparent)?

TheLastProject commented 1 year ago

I don't know how good Android's native support for SVGs is. If this is easy to add, it seems okay, but it'll also be just a very very small group using it so it's important that this implementation stays simple to reduce long-term maintenance.

ukanuk commented 1 year ago

Logos are commonly SVG. Icon packs are very often SVG. I'm not convinced of the assertion that only a very very small group would use it.

In any case, external libraries make it relatively easy to add support. For example com.caverock.androidsvg was chosen for use by another FOSS android app Aegis, which has also has a homescreen with user-imported logos/icons.

Aegis originally only supported PNG, but added SVG support two years ago as part of https://github.com/beemdevelopment/Aegis/issues/509. Searching their code for svg shows updates weren't needed in very many places. https://github.com/search?q=repo%3Abeemdevelopment%2FAegis%20svg&type=code