CatimaLoyalty / Android

Catima, a Loyalty Card & Ticket Manager for Android
https://catima.app
GNU General Public License v3.0
820 stars 150 forks source link

Switch to using photo picker #1261

Open TheLastProject opened 1 year ago

TheLastProject commented 1 year ago

It's the new standard, let's use it:

https://developer.android.com/training/data-storage/shared/photopicker

I don't want to bother with auto-installing this stuff from Google Play Services, I personally dislike apps doing system-level things without permission. Just use it if available. We'll always use the picker for just one single image.

This will apply to all photo pickers. So:

kevinMerizalde commented 1 year ago

I want to help with this. Could you assign this issue to me please?

TheLastProject commented 1 year ago

Sure, good luck and thanks for wanting to help :)

akwa-peter commented 1 year ago

@kevinMerizalde are you currently working on this?

TheLastProject commented 1 year ago

This is currently not possible to implement because Google's photo picker hides many of the user's pictures: https://github.com/CatimaLoyalty/Android/pull/1288#issuecomment-1553435441

Abdullahkhanspn commented 1 year ago

i will do this please assign to me can you explain this issue please @TheLastProject

rzuhovski0 commented 5 days ago

Hello, is this issue still open? I would like to take a look at it.

TheLastProject commented 5 days ago

As written above, this was already implemented in #1288 but it can't be merged because the photo picker doesn't show all of the user's images. Unless you know a way to fix that this issue is blocked and cannot be completed.